Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T366873 do not remove preview when W icon is clicked #125

Merged
merged 1 commit into from
Jun 12, 2024
Merged

T366873 do not remove preview when W icon is clicked #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/link/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@
const toolbarButtonRef = useRef();

const formatButtonClick = () => {
if ( isActive ) {
removeAttributes();
} else {
if ( ! isActive ) {
startAddingPreview();
}
};
Expand Down Expand Up @@ -184,7 +182,7 @@
const formatEnd = getFormatEnd( value.end + 1 );
onChange( removeFormat( value, formatType, formatStart, formatEnd ) );
}
}, [ value.formats ] );

Check warning on line 185 in src/link/edit.js

View workflow job for this annotation

GitHub Actions / build 

React Hook useEffect has missing dependencies: 'getFormatEnd', 'getFormatStart', 'onChange', 'removesPreviewFormat', and 'value'. Either include them or remove the dependency array. If 'onChange' changes too often, find the parent component that defines it and wrap that definition in useCallback

useEffect( () => {
// Update lastValue with the previous value
Expand Down
Loading