Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T367115
While working on #122, I noticed this bug on main when trying to fix the warning associated with the preview format removal feature. This seems to have been introduced in #116, where a change was made to use
useRef
to keep track ofvalue
changes. The fix presented here takes the best of the past solutions:valueRef
to keep track of previous value, but simplify as we don't really needlastValue
statehandleTextFormatRemoval
instead ofremovesPreviewFormat
as the former is more robustPlease test carefully