-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new version of WP and update dependencies #101
Conversation
Most (or all) js files in this PR remove spaces insides parenthesis, which goes against WMF standards. I'm wondering why this is happening now. Have wordpress standards changed? Should we include eslint-wikimedia preset? |
That's a good question. I couldn't find the exact pinpoint in a changelog where the change is reflected, but it looks like
More info here: https://developer.wordpress.org/block-editor/reference-guides/packages/packages-eslint-plugin/#usage and here https://wordpress.org/support/topic/eslint-pluginwordpress-eslint-plugin-not-settings-spaces/ I think I'm leaning towards keeping the spaces just to simplify this PR. Thoughts? |
I agree and I prefer to stay closer to WMF standards than Wordpress standards when they conflict. |
scripts
folder