Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support computers with touch screen #215

Merged
merged 18 commits into from
Jul 25, 2024
Merged

Support computers with touch screen #215

merged 18 commits into from
Jul 25, 2024

Conversation

stephanebisson
Copy link
Collaborator

@stephanebisson stephanebisson commented Jun 5, 2024 •
edited
Loading

Phab: https://phabricator.wikimedia.org/T257574
Demo: https://wikimedia.github.io/wikipedia-preview/desktop-touch/

  • Popup position based on width
  • mouseenter event for both pointer and touch

@stephanebisson stephanebisson marked this pull request as ready for review June 14, 2024 20:07
@stephanebisson stephanebisson requested review from medied and hueitan June 14, 2024 20:07
hueitan
hueitan approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for me 🎉

@medied medied merged commit 29bc25b into main Jul 25, 2024
1 check passed
@medied medied deleted the desktop-touch branch July 25, 2024 17:36
@hueitan hueitan mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medied medied medied approved these changes

@hueitan hueitan hueitan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanebisson @hueitan @medied