Use discardable return in func return to allow better tetsing

wikimedia · Oct 11, 2024 · b5b677b · b5b677b
1 parent 5b213a7
commit b5b677b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/WMFData/Sources/WMFData/Data Controllers/Year In Review/WMFYearInReviewDataController.swift b/WMFData/Sources/WMFData/Data Controllers/Year In Review/WMFYearInReviewDataController.swift
@@ -43,10 +43,11 @@ public class WMFYearInReviewDataController {
  return true
  }
 
- public func createOrRetrieveYearInReview(for year: Int, countryCode: String, primaryAppLanguageProject: WMFProject?) async {
+ @discardableResult
+ public func createOrRetrieveYearInReview(for year: Int, countryCode: String, primaryAppLanguageProject: WMFProject?) async -> WMFYearInReviewReport? {
 
  guard shouldCreateOrRetrieveYearInReview(countryCode: countryCode, primaryAppLanguageProject: primaryAppLanguageProject) else {
- return
+ return nil
  }
 
  var report = try? await fetchYearInReviewReport(forYear: year)
@@ -58,6 +59,7 @@ public class WMFYearInReviewDataController {
  report = try? await fetchYearInReviewReport(forYear: year)
  }
 
+ return report
  }
 
  func getSlides() -> [WMFYearInReviewSlide] {