-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MediaWiki core hooks #33
Conversation
and export it so we can use it with mw.hook('postEdit')
@@ -23,15 +23,16 @@ | |||
}, | |||
"homepage": "https://github.com/wikimedia-gadgets/types-mediawiki#readme", | |||
"dependencies": { | |||
"@types/jquery": "^3.5.5" | |||
"@types/jquery": "^3.5.5", | |||
"@types/oojs-ui": "^0.46.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this create a circular dependency issue? I would assume @types/oojs-ui
itself depends on this package. cc @diskdance @ChlodAlejandro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright I guess let's do this then
check other authors/commits at wikimedia-gadgets#33
check other authors/commits at wikimedia-gadgets#33
Add definitions and basic documentation for the hooks used in MediaWiki core, as mentioned in #26.
Hook names have been retrieved from a source code search, so there may be some missing, I do not know if there is a full list somewhere.
Notes (on things I'm not sure about):
apisandbox.formatRequest
andwikipage.diff.diffTypeSwitch
hooks reference OOUI objects, so it is added as a dependency.mw.user
is used in thepostEdit
hook, so it has been moved into a separateUser
class.