Update tsconfig to use ES6, add troubleshooting in README

.github/workflows/node-ci.yml

@@ -14,10 +14,10 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.repository != 'wikimedia-gadgets/twinkle-starter' }}
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
       - run: npm ci
       - run: npm run lint
       - run: npm run build

README.md

@@ -243,6 +243,10 @@ Do check regularly for new twinkle-core releases, since dependabot wouldn't be a
 
 </details>
 
+## Troubleshooting
+- Getting `JavaScript parse error (scripts need to be valid ES5)` after deploying the output of `grunt build`:
+  - This is because your wiki doesn't support ES6 for JavaScript (only supported in MW 1.42+). Please change the `target` field in `webpack.config.js` and `tsconfig.json` files from `es6` to `es5`.
+
 ## Need help?
 
 Channels for reporting issues or seeking help include:

tests/integration/docker/main.sh

@@ -1,4 +1,4 @@
-docker-compose up --detach --build
+docker compose up --detach --build
 sleep 15 # need to give some time for the database to start working properly
 
-docker exec docker_mediawiki_1 bash /var/www/html/setup.sh
+docker compose exec mediawiki bash /var/www/html/setup.sh

tsconfig.json

@@ -1,13 +1,11 @@
 {
+	/* Visit https://aka.ms/tsconfig.json to read more about this file */
 	"compilerOptions": {
-		/* Visit https://aka.ms/tsconfig.json to read more about this file */
-		"target": "ES5",
-		"module": "ES2020",
+		"target": "es6",
+		"module": "es2020",
 		"lib": [
 			"dom",
-			"es5",
-			"es2015.collection"
-			// Only Map and Set from this are supported in IE 11.
+			"es6",
 		],
 		"outDir": "./build",
 		"sourceMap": true,