Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double signature bug #348

Conversation

NovemLinguae
Copy link
Member

@NovemLinguae NovemLinguae commented Apr 24, 2024

fix double signature bug

  • fix double signature bug by moving signatures slightly (moving them from inside the template to outside the template). this will allow the discussiontoolsedit API to detect that they are already present, preventing it from automatically adding an additional signature
  • update hard-coded template names in the software to modern template names, so that the software is not following redirects
  • this patch needs to be paired with a modification to https://en.wikipedia.org/wiki/Template:AfC_notification to remove the hard-coded signature from the comment case

Sandbox with signatures in the NEW position (the position after merging this patch): https://en.wikipedia.org/w/index.php?title=User:Novem_Linguae/sandbox&oldid=1220495280

Fixes #347

image

@NovemLinguae
Copy link
Member Author

@primefac, are you OK with this patch that scoots the signature down? If so I'll expedite it to fix the double signature bug.

@NovemLinguae
Copy link
Member Author

Abandoning in favor of #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant