Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto subscribe to user talk messages #337

Merged
merged 13 commits into from
Apr 23, 2024

Conversation

NovemLinguae
Copy link
Member

@NovemLinguae NovemLinguae commented Apr 14, 2024

Feature

  • lets the AFC reviewer set a preference to auto subscribe to user talk messages AFCH makes
  • preference defaults to off
  • this is for user talk messages sent via accept, decline, reject, and comment

Technical details

  • had to change some CSS code so that wrapping long preferences works better on the preferences screen
  • messages with subscribe: true are now left with the discussiontoolsedit API insteads of the edit API. this makes it easy to subscribe while AFCH is making the edit, and is much easier than the other approach I tried, which used 3 API calls (edit, discussiontoolspageinfo, discussiontoolssubscribe)

Fixes #258

image

image

@NovemLinguae NovemLinguae marked this pull request as ready for review April 17, 2024 02:30
@NovemLinguae NovemLinguae merged commit 80b9461 into wikimedia-gadgets:master Apr 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto subscribe user to user talk sections
1 participant