add more eslint-config-wikimedia rules. apply autofixes (#375)

- add more eslint-config-wikimedia rules
- apply autofixes
- set un-autofixed errors to warn or off
- add server.js to .eslintignore since I couldn't figure out how to handle that error

.eslintignore

@@ -0,0 +1 @@
+server.js

.eslintrc.json

@@ -1,5 +1,9 @@
 {
-	"extends": "wikimedia",
+	"extends": [
+		"wikimedia/client/es6",
+		"wikimedia/jquery",
+		"wikimedia/mediawiki"
+	],
 	"env": {
 		"browser": true,
 		"jquery": true
@@ -25,15 +29,31 @@
 	"rules": {
 		"camelcase": "off",
 		"eqeqeq": "warn",
+		"es-x/no-array-prototype-includes": "warn",
+		"es-x/no-object-values": "warn",
+		"es-x/no-regexp-s-flag": "warn",
 		"max-len": "off",
 		"no-console": "off",
 		"no-global-assign": "warn",
 		"no-implicit-globals": "warn",
+		"no-jquery/no-animate": "warn",
+		"no-jquery/no-class-state": "off",
+		"no-jquery/no-each-util": "warn",
+		"no-jquery/no-extend": "off",
+		"no-jquery/no-global-selector": "off",
+		"no-jquery/no-grep": "warn",
+		"no-jquery/no-in-array": "warn",
+		"no-jquery/no-map-util": "warn",
+		"no-jquery/no-sizzle": "warn",
+		"no-jquery/no-slide": "warn",
+		"no-jquery/no-trim": "warn",
+		"no-jquery/variable-pattern": "warn",
 		"no-new": "warn",
 		"no-prototype-builtins": "off",
 		"no-shadow": "off",
 		"no-undef": "warn",
 		"no-underscore-dangle": "off",
+		"prefer-const": "warn",
 		"security/detect-non-literal-regexp": "off",
 		"security/detect-unsafe-regex": "off",
 		"unicorn/prefer-string-slice": "off"

src/afch.js

@@ -3,8 +3,8 @@
 	// Check that we're in the right namespace and on the right page
 	switch ( mw.config.get( 'wgNamespaceNumber' ) ) {
 		case 4: // Wikipedia
-		case 5: // Wikipedia talk
-			var pageName = mw.config.get( 'wgTitle' );
+		case 5: { // Wikipedia talk
+			const pageName = mw.config.get( 'wgTitle' );
 			// return nothing for now, all drafts are now under Draft namespace
 			// currently only the article submission script is running here.
 			// to be used when script(s) for other modules such as category and
@@ -13,6 +13,7 @@
 				return;
 			}
 			break;
+		}
 		case 2: // User
 		case 118: // Draft
 			break;
@@ -35,8 +36,8 @@
 	AFCH.consts.baseurl = AFCH.consts.scriptpath +
 		'?action=raw&ctype=text/javascript&title=MediaWiki:Gadget-afch.js';
 
-	$.getScript( AFCH.consts.baseurl + '/core.js' ).done( function () {
-		var loaded = AFCH.load( 'submissions' ); // perhaps eventually there will be more modules besides just 'submissions'
+	$.getScript( AFCH.consts.baseurl + '/core.js' ).done( () => {
+		const loaded = AFCH.load( 'submissions' ); // perhaps eventually there will be more modules besides just 'submissions'
 		if ( !loaded ) {
 			mw.notify( 'AFCH could not be loaded: ' + ( AFCH.error || 'unknown error' ),
 				{ title: 'AFCH error' } );