Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue-1103: always display two months on mobile #1116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danielappelt
Copy link
Contributor

@danielappelt danielappelt commented Sep 30, 2022

This PR changes the frontend calendar to always display two months on mobile (cf. resolves #1103 ).

Could someone please create the minified version of the affected JS file and add it to this PR? Unfortunately, I don't know how to do it.

@datengraben
Copy link
Contributor

datengraben commented Mar 4, 2023

@danielappelt @hansmorb
I created the minified assets via $ grunt dist after installing ruby and the Compass gem.

~/Code/commonsbooking on bugfix/issue-1103 *10 !3 ?3                                                                                                                                                            took 25s Py base at 10:30:58
❯ grunt dist
(node:9809) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
Running "compass:admin" (compass) task

Running "compass:public" (compass) task

Running "compass:themes" (compass) task

Running "uglify:dist" (uglify) task
>> 3 files created 212 kB → 109 kB

Running "babel:dist" (babel) task

Done.

Also I rebased the branch onto master.

@datengraben datengraben requested review from hansmorb and markus-mw and removed request for hansmorb and markus-mw March 13, 2023 13:58
@hansmorb
Copy link
Contributor

Das Problem ist, dass der litepicker source eigentlich aus einer anderen repo kommt: https://github.com/markus-mw/Litepicker

Also eigentlich müsste es auch da geändert werden damit es nicht von zukünftigen Änderungen überschrieben wird

@hansmorb hansmorb added the enhancement New feature or request label Mar 16, 2023
@hansmorb hansmorb added this to the 2.8.1 milestone Apr 26, 2023
@hansmorb hansmorb removed this from the 2.8.1 milestone Jun 12, 2023
@datengraben
Copy link
Contributor

@hansmorb Ich habe wielebenwir/Litepicker#5 erstellt mit der kleinen Änderung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobil (hochkant) keine Buchung über Monatsende hinaus möglich
3 participants