Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: streamline and improve applayout api #657

Draft
wants to merge 1 commit into
base: 05-21-fix_show_appbar_when_tabs_are_the_only_children
Choose a base branch
from

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented May 21, 2024

Fixes #584.

Includes four breaking changes:

  • A change in the default color of the AppBar from "primary" to the Vuetify default (light/dark grey depending on theme)
  • Changes the behaviour of the navigation argument, where previously it would hide the entire AppBar it now correctly only hides the tab navigation (if present)
  • Changes the default behaviour of show_app_bar (which is now also available as an argument) to where it no longer requires the title-argument to be set for show_app_bar to be true.
  • Do not turn the first non-AppBar child of AppLayout into a sidebar element.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @iisakkirotko and the rest of your teammates on Graphite Graphite

@iisakkirotko iisakkirotko marked this pull request as draft May 21, 2024 16:48
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from bd314ec to 569256e Compare May 21, 2024 17:17
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 1f72013 to 51b28c5 Compare May 22, 2024 07:41
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 569256e to 315d628 Compare May 22, 2024 07:41
@iisakkirotko iisakkirotko added this to the Solara 2.0 milestone May 31, 2024
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 51b28c5 to c34291a Compare June 3, 2024 07:13
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 315d628 to e0483ce Compare June 3, 2024 07:13
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from c34291a to 4ce4cf2 Compare June 3, 2024 14:44
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch 2 times, most recently from 289e509 to 569a43c Compare June 4, 2024 08:02
@iisakkirotko iisakkirotko force-pushed the 05-21-fix_show_appbar_when_tabs_are_the_only_children branch from 504c870 to 5b2fff1 Compare June 4, 2024 08:05
@iisakkirotko iisakkirotko force-pushed the 05-21-refactor_streamline_and_improve_applayout_api branch from 569a43c to cb5426e Compare June 4, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant