Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use solara instead of voila for rendering the popout widget #15

Merged
merged 2 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
- name: Install ipypopout and test deps
run: |
wheel=(dist/*.whl)
pip install ${wheel}[test] ${wheel}[voila] "jupyter_server<2"
pip install ${wheel}[test] ${wheel}[voila,solara] "jupyter_server<2"

- name: Install playwright browsers
run: playwright install chromium
Expand All @@ -94,7 +94,7 @@ jobs:

- name: Upload Test artifacts
if: always()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: ipypopout-test-results
path: test-results
Expand Down
31 changes: 23 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,27 @@ Works with:

* Jupyter notebook
* Jupyter lab
* Voila (`version<0.5`)
* Voila (`version<0.5` only when running standalone)
* [Solara](https://github.com/widgetti/solara/) (`version>=1.22`)

In the Jupyter notebook and Jupyter lab environments, ipypopout will use either Solara or Voila to create the popout window. The exist

## Installation

### To use the Solara backend

```
$ pip install "ipypopout[solara]"
```

### To use the Voila backend

```
$ pip install "ipypopout[voila]"
```

*Note: ipypopout is not compatible with Voila >= 0.5 standalone (e.g. running as `voila mynotebook.ipynb`). If you use Voila >=0.5 as a Jupyter server extension, such as when running Jupyter Lab, ipypopout can only use solara and therefore you need to `pip install ipypopout[solara]`.*

## Usage

### With ipywidgets
Expand Down Expand Up @@ -82,13 +100,6 @@ Because Solara creates elements instead of widgets, we have to use the `use_effe
https://github.com/widgetti/ipypopout/assets/1765949/430cae12-2527-404b-9861-610565ac1471


## Installation

```
$ pip install "ipypopout[voila]"
or
$ pip install "ipypopout[solara]"
```

## API

Expand All @@ -99,3 +110,7 @@ $ pip install "ipypopout[solara]"
* `window_name - str`: If a window with the same name is available it will be reused, otherwise a new window is created (defaults to `target_model_id`).
See [https://developer.mozilla.org/en-US/docs/Web/API/Window/open](https://developer.mozilla.org/en-US/docs/Web/API/Window/open) for more details.
* `window_features - str`: See: [https://developer.mozilla.org/en-US/docs/Web/API/Window/open#window_features](https://developer.mozilla.org/en-US/docs/Web/API/Window/open#window_features)

### Which backend to use

Note that ipypopout will automatically detect if it can use Solara, and use it if available, otherwise it will use Voila. If you want to force the use of Voila, you can set the environment variable `IPYPOPOUT_USE_BACKEND=voila`, the other options are `auto` (the default) and `solara` (in case our auto detect fails).
5 changes: 5 additions & 0 deletions ipypopout/popout_button.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
import sys


DEFAULT_USE_BACKEND = os.environ.get("IPYPOPOUT_USE_BACKEND", "auto")


def get_kernel_id():
if "solara" in sys.modules:
import solara
Expand Down Expand Up @@ -38,6 +41,8 @@ class PopoutButton(v.VuetifyTemplate):
target = traitlets.Instance(ipywidgets.Widget, allow_none=True)
echo_available = traitlets.Bool(False).tag(sync=True)

use_backend = traitlets.Enum(values=["auto", "voila", "solara"], default_value=DEFAULT_USE_BACKEND).tag(sync=True)

is_displayed = traitlets.Bool(False).tag(sync=True)
open_window_on_display = traitlets.Bool(False).tag(sync=True)
open_tab_on_display = traitlets.Bool(False).tag(sync=True)
Expand Down
25 changes: 23 additions & 2 deletions ipypopout/popout_button.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,22 @@
</template>
<script>
module.exports = {
data() {
return {solaraFound: false}
},
created() {
if (!this.getBaseUrl()) {
const baseUrl = this.getBaseUrl();
if (!baseUrl) {
console.info('BaseUrl not found, hiding popout button.');
} else {
const solaraReadyZUrl = `${baseUrl}solara/readyz`;
fetch(solaraReadyZUrl)
.then(response => {
if (response.ok) {
console.error('Solara found, using Solara popout page.');
this.solaraFound = true;
}
})
}
},
mounted() {
Expand All @@ -31,6 +44,10 @@ module.exports = {
},
methods: {
getBaseUrl() {
if(window.solara) {
// if on solara >=1.40, the jupyter base url is different from the solara one
return window.solara.rootPath + "/";
}
const labConfigData = document.getElementById('jupyter-config-data');
if (labConfigData) {
/* lab, Voila, and Solara */
Expand Down Expand Up @@ -69,7 +86,11 @@ module.exports = {
if (window.solara && (solara.rootPath !== undefined)) {
return ""
}
return 'voila/templates/ipypopout/static/popout.html'
if(this.use_backend == "solara" || (this.use_backend == "auto" && this.solaraFound)) {
return 'solara';
} else {
return 'voila/templates/ipypopout/static/popout.html'
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,10 @@ def get_data_files(target, src):
"solara[pytest]",
],
"voila": [
"voila>=0.2.10,<0.5"
'voila>=0.2.10,<0.5'
],
"solara": [
"solara>=1.36"
'solara-server>=1.40.0'
]
},
data_files=get_data_files(os.path.join(*share_voila_target), os.path.join(template[0])),
Expand Down
Loading