Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 7.1 #30

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Add support for Rails 7.1 #30

merged 1 commit into from
Nov 5, 2023

Conversation

pyromaniac
Copy link
Contributor

Hey @ka8725, thanks for a great gem.

@pyromaniac pyromaniac force-pushed the main branch 10 times, most recently from b82177d to 8284ce3 Compare November 5, 2023 14:38
@pyromaniac
Copy link
Contributor Author

pyromaniac commented Nov 5, 2023

Ok, it looks like Rails 6.0 is not supported by the current implementation since ActiveRecord::MigrationProxy is a simple struct there and doesn't have the role yet.

I either need help fixing it or a permission to drop 6.0 support here.

@ka8725
Copy link
Member

ka8725 commented Nov 5, 2023

@pyromaniac does that mean it didn't work with Rails 6.0 even before your changes? I prefer to fix it in a separate ticket. Thanks for your contribution. This work is fantastic!

@ka8725 ka8725 merged commit 125f547 into widefix:main Nov 5, 2023
5 checks passed
@ka8725
Copy link
Member

ka8725 commented Nov 5, 2023

Ticket created #31

@pyromaniac
Copy link
Contributor Author

@ka8725 it appear so to me. Thanks for merging this quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants