multidb support

Gemfile.lock

@@ -122,6 +122,8 @@ GEM
     marcel (1.0.2)
     mini_mime (1.1.5)
     minitest (5.20.0)
+    minitest-around (0.5.0)
+      minitest (~> 5.0)
     mutex_m (0.1.2)
     net-imap (0.4.4)
       date
@@ -230,6 +232,7 @@ DEPENDENCIES
   appraisal
   debug
   minitest (~> 5.0)
+  minitest-around
   rails
   rake
   rubocop (~> 1.21)

actual_db_schema.gemspec

@@ -41,6 +41,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "appraisal"
   spec.add_development_dependency "debug"
+  spec.add_development_dependency "minitest-around"
   spec.add_development_dependency "rails"
   spec.add_development_dependency "sqlite3"
 

lib/actual_db_schema/commands/base.rb

@@ -9,10 +9,6 @@ def call
           raise "ActualDbSchema is disabled. Set ActualDbSchema.config[:enabled] = true to enable it."
         end
 
-        if ActiveRecord::Migration.current_version >= 6
-          ActiveRecord::Tasks::DatabaseTasks.raise_for_multi_db(command: "db:rollback_branches")
-        end
-
         call_impl
       end
 

lib/actual_db_schema/patches/migration_context.rb

@@ -32,7 +32,7 @@ def down_migrator_for(migration)
       def migration_files
         paths = Array(migrations_paths)
         current_branch_files = Dir[*paths.flat_map { |path| "#{path}/**/[0-9]*_*.rb" }]
-        other_branches_files = Dir["#{ActualDbSchema.migrated_folder}/**/[0-9]*_*.rb"]
+        other_branches_files = Dir[*ActualDbSchema.migrated_folders.flat_map { |path| "#{path}/**/[0-9]*_*.rb" }]
 
         current_branch_file_names = current_branch_files.map { |f| ActualDbSchema.migration_filename(f) }
         other_branches_files.reject { |f| ActualDbSchema.migration_filename(f).in?(current_branch_file_names) }

lib/actual_db_schema/store.rb

@@ -34,7 +34,7 @@ def record_metadata(filename)
     end
 
     def folder
-      ActualDbSchema.migrated_folder
+      ActualDbSchema.migrated_folders.first
     end
 
     def store_file

test/dummy_app/db/secondary_schema.rb

@@ -0,0 +1,14 @@
+# This file is auto-generated from the current state of the database. Instead
+# of editing this file, please use the migrations feature of Active Record to
+# incrementally modify your database, and then regenerate this schema definition.
+#
+# This file is the source Rails uses to define your schema when running `bin/rails
+# db:schema:load`. When creating a new database, `bin/rails db:schema:load` tends to
+# be faster and is potentially less error prone than running all of your
+# migrations from scratch. Old migrations may fail to apply correctly if those
+# migrations use external dependencies or application code.
+#
+# It's strongly recommended that you check this file into your version control system.
+
+ActiveRecord::Schema[7.1].define(version: 2013_09_06_111513) do
+end

test/rake_task_secondary_test.rb

@@ -0,0 +1,88 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+describe "multiple databases support" do
+  let(:utils) do
+    TestUtils.new(migrations_path: "db/migrate_secondary", migrated_path: "tmp/migrated_migrate_secondary")
+  end
+
+  around do |block|
+    original_db_config = ActiveRecord::Base.connection_db_config
+    ActiveRecord::Base.establish_connection(TestingState.db_config["secondary"])
+    utils.cleanup
+    block.call
+  ensure
+    ActiveRecord::Base.establish_connection(original_db_config)
+  end
+
+  describe "db:rollback_branches" do
+    it "creates the tmp/migrated_migrate_secondary folder" do
+      refute File.exist?(utils.app_file("tmp/migrated_migrate_secondary"))
+      utils.run_migrations
+      assert File.exist?(utils.app_file("tmp/migrated_migrate_secondary"))
+    end
+
+    it "migrates the migrations" do
+      assert_empty utils.applied_migrations
+      utils.run_migrations
+      assert_equal %w[20130906111511 20130906111512], utils.applied_migrations
+    end
+
+    it "keeps migrated migrations in tmp/migrated folder" do
+      utils.run_migrations
+      assert_equal %w[20130906111511_first.rb 20130906111512_second.rb], utils.migrated_files
+    end
+
+    it "rolls back the migrations in the reversed order" do
+      utils.prepare_phantom_migrations
+      assert_empty TestingState.down
+      utils.run_migrations
+      assert_equal %i[second first], TestingState.down
+    end
+
+    describe "with irreversible migration" do
+      before do
+        utils.define_migration_file("20130906111513_irreversible.rb", <<~RUBY)
+          class Irreversible < ActiveRecord::Migration[6.0]
+            def up
+              TestingState.up << :irreversible
+            end
+
+            def down
+              raise ActiveRecord::IrreversibleMigration
+            end
+          end
+        RUBY
+      end
+
+      it "keeps track of the irreversible migrations" do
+        utils.prepare_phantom_migrations
+        assert_equal %i[first second irreversible], TestingState.up
+        assert_empty ActualDbSchema.failed
+        utils.run_migrations
+        assert_equal(%w[20130906111513_irreversible.rb], ActualDbSchema.failed.map { |m| File.basename(m.filename) })
+      end
+    end
+  end
+
+  describe "db:phantom_migrations" do
+    it "shows the list of phantom migrations" do
+      ActualDbSchema::Git.stub(:current_branch, "fix-bug") do
+        utils.prepare_phantom_migrations
+        Rake::Task["db:phantom_migrations"].invoke
+        Rake::Task["db:phantom_migrations"].reenable
+        assert_match(/ Status   Migration ID    Branch   Migration File/, TestingState.output)
+        assert_match(/---------------------------------------------------/, TestingState.output)
+        assert_match(
+          %r{   up     20130906111511  fix-bug  tmp/migrated_migrate_secondary/20130906111511_first.rb},
+          TestingState.output
+        )
+        assert_match(
+          %r{   up     20130906111512  fix-bug  tmp/migrated_migrate_secondary/20130906111512_second.rb},
+          TestingState.output
+        )
+      end
+    end
+  end
+end

test/test_helper.rb

@@ -4,6 +4,7 @@
 require "rails/all"
 require "actual_db_schema"
 require "minitest/autorun"
+require "minitest/around/spec"
 require "debug"
 require "support/test_utils"
 
@@ -18,20 +19,25 @@ def initialize
 
 Rails.application = FakeApplication.new
 
-db_config = {
-  adapter: "sqlite3",
-  database: "tmp/test.sqlite3"
-}
-ActiveRecord::Tasks::DatabaseTasks.database_configuration = { test: db_config }
-ActiveRecord::Base.establish_connection(**db_config)
-
-ActualDbSchema.config[:enabled] = true
-
 class TestingState
   class << self
     attr_accessor :up, :down, :output
   end
 
+  def self.db_config
+    {
+      "primary" => {
+        adapter: "sqlite3",
+        database: "tmp/primary.sqlite3"
+      },
+      "secondary" => {
+        adapter: "sqlite3",
+        database: "tmp/secondary.sqlite3",
+        migrations_paths: Rails.root.join("db", "migrate_secondary").to_s
+      }
+    }
+  end
+
   def self.reset
     self.up = []
     self.down = []
@@ -41,6 +47,11 @@ def self.reset
   reset
 end
 
+ActiveRecord::Tasks::DatabaseTasks.database_configuration = { "test" => TestingState.db_config }
+ActiveRecord::Base.establish_connection(TestingState.db_config["primary"])
+
+ActualDbSchema.config[:enabled] = true
+
 module Kernel
   alias original_puts puts