-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace npm
with yarn
; add CI workflow to run TSC and tslint checks
#699
base: main
Are you sure you want to change the base?
Conversation
…h tsconfig file. Fix resulting identified issues.
…cycle-interface`. Fixes a warning in CI. > Could not find implementations for the following rules specified in the configuration: use-life-cycle-interface > Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed. > Lint was recently upgraded, you may have old rules configured which need to be cleaned up. mgechev/codelyzer#791 (comment)
Thank you for the contribution! I'll give it a try on Mac and Windows to see how it goes. I remember when I'm not opposed to merging this -- I'll try it out first 🙇 |
Yep, I'd be happy to stick with Plus, I noticed If you look at the number of lines changed, this MR removes approx 30,000 lines. Maybe it's because |
To avoid linting issue sneaking in, particularly in the backend/server code, I've added a GitHub Action workflow to run
tsc
andtslint
on every push.yarn
behaves better across different execution environments. In particular,npm ci
failed to run in a GitHub Action, due tofsevents
being a required dependency (somehow).Example CI check:
https://github.com/laurence-myers/Video-Hub-App/runs/3578230215?check_suite_focus=true
This PR is based on #698, and includes its changes.