Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9 by using LF line-endings #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ensconced
Copy link

@ensconced ensconced commented Apr 10, 2021

fixes #9

After merging this in, to actually see the fixed line-endings in your working tree, you'll need to clear out your working directory, and then restore everything again by doing this:

(N.B. this will clear out any uncommitted changes you have on your branch).

git rm -r ./* && git reset --hard

Then if you open bin/index.js you should see that the line-endings are just LF rather than CR+LF. I tested this in Notepad++ (View > Show Symbol > Show End of Line).

ensconced and others added 2 commits April 10, 2021 08:24
this ensures that the bin scripts in the published package are unix-compatible
@whyboris
Copy link
Owner

whyboris commented Oct 8, 2021

Thank you for this contribution 🙇
Sorry it's taking a while for me to get to it 😓 I've been busy with life stuff (not bad, just time-consuming).
I intend to get this merged in before the end of the year 🤞

@whyboris
Copy link
Owner

whyboris commented Jan 4, 2022

Thank you again for this -- I'll test it on Windows once and merge 🤝

This was a great article about the topic:
https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/

I might try the command from the article git add --renormalize . 🤝

@whyboris
Copy link
Owner

Intending to merge/fix this problem in the coming month 🤞

@whyboris
Copy link
Owner

I'm hoping to catch up on updating all my repositories this winter 😅

@whyboris
Copy link
Owner

whyboris commented Nov 2, 2024

😓 oh it's been busy years for me ... hoping to get back to cleaning my less-frequently-used-by-me repositories in 2025 🤞

Thank you again for the PR - it's not forgotten 🙇‍♂️ ♥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doesn't work with yarn due to CRLF line-ending
2 participants