Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

retry 3 times on network issues #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shoeper
Copy link

@shoeper shoeper commented Nov 2, 2022

I had issues with ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')) and ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) which could be solved by retrying up to three times.

@whoot
Copy link
Owner

whoot commented Dec 12, 2022

Hi, this seems to be a network issue and not something tool related.
Also instead of printing the error message on every failed connection, it would be better to do the retries first and if it fails on the last retry print the error message.

@shoeper
Copy link
Author

shoeper commented Dec 16, 2022

Hi, I agree it is no problem of the tool, but the webserver had issues. So I couldn't test it with typo3scan until hacking this fix. Submitted it in case somebody runs into a similar issue. Actually, I'm not sure on the error message, because it may still be something one wants to be aware of.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants