Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #500

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Bump dependencies #500

merged 2 commits into from
Jan 17, 2025

Conversation

faisal
Copy link
Contributor

@faisal faisal commented Dec 24, 2024

  • Bump dependencies to the latest available that pass with all currently-supported Rubies.
  • Add gems that have been removed from the standard library in Ruby HEAD.

Note that the CHANGELOG will probably need some reworking before a release. Since we currently have lines for dropping both Ruby 2.7 and 3.0, and lines for dropping two overlapping sets of dependencies.

Check list:

@faisal
Copy link
Contributor Author

faisal commented Dec 24, 2024

Observations on that Cucumber failure:

  1. It's the same "this will be fixed in Cucumber 10" bug that was holding up other recent PRs.
  2. The tests passed locally on 3.4 RC1

Unless somebody wants these changes now, I plan to wait for Cucumber 10 to land and check with that.

@faisal
Copy link
Contributor Author

faisal commented Jan 6, 2025

I suspect we'll want to hold this open until Cucumber 10 lands.

@faisal
Copy link
Contributor Author

faisal commented Jan 10, 2025

I can reproduce that jruby failure locally. Investigating ...

@faisal
Copy link
Contributor Author

faisal commented Jan 12, 2025

This latest push picks up a newer Cucumber, which includes a limited fix for the keywords issue that is causing things to fail on 3.4. I also need to update the CI to include 3.4, and then investigate this new failure on HEAD.

@faisal faisal changed the title WIP: Bump dependencies Bump dependencies Jan 14, 2025
@faisal
Copy link
Contributor Author

faisal commented Jan 14, 2025

Adding a BOM doesn't keep jruby from complaining about the BOM, so I'll revert that on a subsequent push.

- Bump aruba, cucumber, fakefs, mocha, reek, rubocop dependencies to most recent versions.
- Introduce explicit development dependencies for irb, ostruct, and rdoc gems since they were removed from Ruby HEAD.
Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@faisal Looks good to me, thank you!

@etagwerker etagwerker merged commit 3bfdf93 into whitesmith:main Jan 17, 2025
25 of 26 checks passed
@faisal faisal deleted the update_gems branch January 17, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants