Drop support for Ruby 3.0, and adopt Rubycritic changes for Ruby 3.1. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etagwerker @nunosilva800 Regarding Rubocop's preference |
- Drop support for Ruby 3.0. - Update Rubycritic config to target Ruby 3.1. Apply all safe autocorrections except for Style/HashSyntax. - Set Rubycritic's Style/HashSyntax EnforcedShorthandSyntax to 'never', which keeps the old style in place (and consistent) until we decide to convert. - Add Ruby 3.3 to the test matrix and Drop Ruby 3.0 (which largely includes the changes in whitesmith#488, so we'll need to rebase if that's landed when we do something with this) - Bump minitest, mocha, rubocop dependencies
|
The failure in 3.4 seems to be an issue with running cucumber on ruby 3.4-dev, and unrelated to this project. I can reproduce it elsewhere, even on null projects. |
|
etagwerker
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have not yet dropped support for Ruby 2.7 (EOL'd over a year ago), Ruby 3.0 EOL'd a couple months ago and this PR does the work to move forward from there.
Check list: