Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a branch in detached HEAD state #424

Merged

Conversation

h-r-k-matsumoto
Copy link
Contributor

This PR would resolve issue #346

The code below has a problem if check out a branch in the state of detached HEAD.
https://github.com/whitesmith/rubycritic/blob/main/lib/rubycritic/source_control_systems/git.rb#L82-L85

Even in that case, it can be run successfully with this change.

Check list:

h-r-k-matsumoto and others added 2 commits January 12, 2023 08:17
Fix issue whitesmith#346

This commit prevents `sh: 1: Syntax error: "(" unexpected` error and completes the run with compare mode successfully.
Copy link
Collaborator

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-r-k-matsumoto I like this idea. Thank you! ❤️

@etagwerker etagwerker merged commit 212aab4 into whitesmith:main Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants