Fix compare file structure #378
Conversation
|
@etagwerker, as you commented on the issue, perhaps you could review this when you get a chance? I went for a minimal intervention approach here - just stashing a copy of the root path before it starts being changed, and using that copy as the 'source of truth' in the method that was concatenating successive changes before. I think a more correct solution would be not to change Config.root_path at all - it doesn't sound like something that should be mutable - but fixing that looked like it would involve changing a lot more code. |
There was a problem hiding this comment.
@denny Looks good 👍
Could you please update the CHANGELOG as well?
|
Oh yeah, sorry, I meant to ask about that; what do I do about version numbers for the changelog, am I meant to bump the patch level in the PR and use the new number? |
|
@denny if you can add a note that's fine. I'll bump the version right before I cut a new release. For reference you can check some of the latest PRs we have merged. Thank you! ❤️ |
This PR fixes issue #287; the reports for both branches and the diff report all end up where the top-of-page links expect them to be (which is also where humans expect them to be, going by the comments on that issue).