Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependent field support #497

Closed
wants to merge 6 commits into from
Closed

Fix dependent field support #497

wants to merge 6 commits into from

Conversation

wize-wiz
Copy link

As discussed in #492.

Basically adds a routes/nova-api.php to patch the native /nova-api/{resource}/{resourceId}/update-fields route with a src/Http/Controllers/UpdateFieldController extending the Novas Laravel\Nova\Http\Controllers\UpdateFieldController, using a modified sync version only if the $request->query('field') is a flexible field.

Let me know if anything else should be done.

@wize-wiz wize-wiz changed the title Feature dependent field support Fix dependent field support Jan 14, 2024
@wize-wiz
Copy link
Author

wize-wiz commented Jan 22, 2024

Added the creation-fields to the list of routes being overwritten. Need some time to build a scenario to find out where the pivot-field routes are being called to support these as well.

@andrii-trush
Copy link

@wize-wiz I have detected an issue. As soon as You are in edit mode of the resource, it doesn't show dependedOn elements until You deselect and then select again.

Looks need to rewrite this route too Route::get('/{resource}/{resourceId}/update-fields', UpdateFieldController::class)

@wize-wiz
Copy link
Author

@andrii-trush He ho, I didn't had any issues in edit-mode, are you using the latest commit? abcf902

I'm also not going to work on Nova or anything related to Nova anymore.

Since this package wasn't the only troubled thing, it seems Nova isn't going anywhere soon the way it handles 3rd party packages. It's the same mess since 3 years ago I last used Nova for a project.

I've since switched to Filament and it's by far the best thing available.

@wize-wiz wize-wiz closed this by deleting the head repository Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants