Added a test for Yahoo finance data in 'Head and shoulder' conformation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a function to predict all the pattern types
The test pass for all bot triple tops, triple bottoms and descending triangles
white07S
reviewed
May 5, 2023
| start_date = dt.datetime.fromisoformat('2023-05-04T02:51:56.734028') | ||
| end_date = dt.datetime.fromisoformat('2023-05-04T04:51:56.734028') | ||
|
|
||
| gold_data = yf.download("TSLA", start=start_date, end=end_date, interval="15m") |
There was a problem hiding this comment.
Make sure the name of variable is correct and also cross verify if the start and end params are working
| df_triple_top = generate_sample_df_with_pattern("Triple Top") | ||
| df_triple_bottom = generate_sample_df_with_pattern("Triple Bottom") | ||
|
|
||
| plot_patterns(df_head_shoulder) |
There was a problem hiding this comment.
Do let me know if you are working on improving the plotting function based on detection rather than just plotting the candlesticks
| @@ -70,14 +71,25 @@ def detect_triangle_pattern(df, window=3): | |||
| df.loc[mask_desc, 'triangle_pattern'] = 'Descending Triangle' | |||
| return df | |||
|
|
|||
| def trend_function(x): | |||
There was a problem hiding this comment.
Good job! Making it more readable
Rahul-2609
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.