Bump itertools to 0.11 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubdos
reviewed
Jun 27, 2023
Co-authored-by: Ruben De Smet <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 71.01% 71.01%
=======================================
Files 19 19
Lines 1956 1956
=======================================
Hits 1389 1389
Misses 567 567 |
rubdos
approved these changes
Jun 28, 2023
|
Thanks :-) |
|
Could we get this into a release, please? Would be nice to avoid the dependency on 0.10. |
mwilliammyers
added a commit
to telcoin/rust-phonenumber
that referenced
this pull request
Dec 13, 2023
* master: (35 commits) Bump version to 0.3.3 Shorter version for +-prefix stripping Split panic test case in two tests Fix a potential panic during parsing Update README build badge with correct link Bump itertools to 0.10-0.11 (whisperfish#58) Use rstest for phone number type test Add `PhoneNumber::number_type` method (whisperfish#57) Avoid Panic when extracting country id for UIFN numbers (whisperfish#54) Add codecov config Set output path for grcov Set correct environment for gcov Run coverage only on nightly Don't fail the tests fast Add coverage analysis and Codecov upload Refer to issues in the commented-out test case Enforce Eq on parsed phone numbers Add National and RFC to round trip test Add test case for parsing round trip Add failing test case as comment ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't see any relevant breaking changes, so this should be OK.