Sqlite store impl #287
Sqlite store impl #287
Conversation
|
I would guess |
Not at all, quite the opposite! These are files that you generate with |
|
Just saying that the official sqlx repo also has it gitignored. Instead, this should probably be generated and checked in CI. |
presage-store-sqlite/presage.sqlite
Outdated
There was a problem hiding this comment.
I think this should also be gitignored. As well as the top-level presage.sqlite.
presage-store-sqlite/src/protocol.rs
Outdated
| let device_id: u32 = address.device_id().into(); | ||
| let record_data = record.serialize()?; | ||
| query!( | ||
| "INSERT INTO sessions ( address, device_id, identity, record ) VALUES ( $1, $2, $3, $4 )", |
There was a problem hiding this comment.
As far as I can see, sessions should also be replaced when they already exist (looking at WF).
The same probably also for the various types of keys.
There was a problem hiding this comment.
Can you give it another look when it's not a draft anymore?
I plan on double checking constraints on tables themselves, and most tables already have PRIMARY KEY(...) ON CONFLICT REPLACE.
gferon
force-pushed
the
sqlite-store-impl
branch
from
c7dc705
to
59cee93
Compare
gferon
force-pushed
the
sqlite-store-impl
branch
from
59cee93
to
22a5497
Compare
No description provided.