-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libsignal-service-rs #230
Conversation
888bbbe
to
0f96270
Compare
I now also updated all other (compatible) dependencies, after the merge of whisperfish/libsignal-service-rs#280. I am currently having issues with building the cli (for reasons unrelated to presage), so I did not update some incompatible packages there. |
0e762df
to
604ad25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think we can remove the todo about the guid, and maybe merge with update pre key bundle for account identity only?
I tested this commit in Gurk. Somehow I get |
604ad25
to
39a0fbc
Compare
Flare does not yet send read receipts, so that did not happen to me. But I guess the error is somewhere in libsignal-service-rs, so maybe ask them about this. |
39a0fbc
to
053a25e
Compare
Quickly tested, LGTM, thanks a lot for working on this! |
Note: I am unsure about a few things, which are marked asTODO
.This should now be ready, with one additional TODO which needs to be implemented once upstream has PNI.