Fix panic for fetching group avatar #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracing assumed the path was always at least 4 characters long. This would panic with the empty path which can be the value of a group avatar path if no avatar is set for the group. While this panic is easy to prevent in presage (which I also did [here](whisperfish/presage@1852f52#diff-99551c60a775f81baa1c0f5ba314ab329a8b187a979ece33826b3f98a02c3fa3R502)), this panic should still be removed from libsignal-service-rs.
4 tasks
shekohex
approved these changes
Feb 21, 2024
I don't think you should call this method when you know the avatar is not set, but I agree it shouldn't panic in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing assumed the path was always at least 4 characters long. This would panic with the empty path which can be the value of a group avatar path if no avatar is set for the group.
While this panic is easy to prevent in presage (which I also did here), this panic should still be removed from libsignal-service-rs.
(CI failure is again in nightly and most likely not my fault)