Fix base64 #289
Merged
Fix base64 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=======================================
Coverage 17.12% 17.12%
=======================================
Files 38 38
Lines 3078 3078
=======================================
Hits 527 527
Misses 2551 2551 ☔ View full report in Codecov by Sentry. |
|
Seems like you miss some imports in |
Schmiddiii
force-pushed
the
base64
branch
2 times, most recently
from
06423bb to
676a066
Compare
rubdos
reviewed
Jan 30, 2024
Schmiddiii
added a commit
to Schmiddiii/presage
that referenced
this pull request
Jan 30, 2024
Main fix is for the error "Invalid padding" for JSON decoding. See <whisperfish/libsignal-service-rs#288> and <whisperfish/libsignal-service-rs#289>.
gferon
pushed a commit
to whisperfish/presage
that referenced
this pull request
Feb 1, 2024
Main fix is for the error "Invalid padding" for JSON decoding. See <whisperfish/libsignal-service-rs#288> and <whisperfish/libsignal-service-rs#289>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288.
Note that
BASE64_STANDARD_NO_PADdoes not work as this requires base64 to not have padding, which is also not the case for Signal. This therefore needs a custom engine.