Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Hyper work with unsend futures #281

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Make Hyper work with unsend futures #281

merged 2 commits into from
Jan 12, 2024

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Jan 10, 2024

Will add compile test to CI too after #283 gets merged.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0b194b2) 17.32% compared to head (699c68c) 17.32%.

Files Patch % Lines
libsignal-service-hyper/src/push_service.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   17.32%   17.32%   -0.01%     
==========================================
  Files          38       38              
  Lines        3053     3054       +1     
==========================================
  Hits          529      529              
- Misses       2524     2525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rubdos rubdos merged commit c3c6a12 into main Jan 12, 2024
21 checks passed
@rubdos rubdos deleted the unsend-hyper-fix branch January 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant