Update some dependencies #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
========================================
- Coverage 3.66% 3.65% -0.02%
========================================
Files 38 38
Lines 2809 2818 +9
========================================
Hits 103 103
- Misses 2706 2715 +9 ☔ View full report in Codecov by Sentry. |
direc85
force-pushed
the
update-dependencies
branch
from
02515fb to
dd9c02e
Compare
direc85
force-pushed
the
update-dependencies
branch
from
dd9c02e to
b8f0bae
Compare
|
In the context of "Whisperfish is getting Rust 1.72 soon^tm", this PR is now in good enough shape to receive a proper code review. I believe @rubdos is also interested in this PR. |
|
I tried updating |
direc85
force-pushed
the
update-dependencies
branch
from
fac0005 to
4b109ab
Compare
direc85
force-pushed
the
update-dependencies
branch
from
4b109ab to
06db57d
Compare
|
LGTM, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating Whisperfish to up-to-date dependencies, this results in dependencies with different versions. This PR attempts to lessen that duplication.
What's notable here, is that Sailfish OS should have Rust 1.72.1 soon*, so currently this PR pays no attention to MSRV.