Skip to content

Commit

Permalink
Add tracing
Browse files Browse the repository at this point in the history
  • Loading branch information
@rubdos
rubdos committed Oct 13, 2023
1 parent 96e4f39 commit c3675b3
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions libsignal-service-actix/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ actix-rt = "2.4"
mpart-async = "0.5"
serde_json = "1.0"
futures = "0.3"
tracing = "0.1"
bytes = "1"
rustls = "0.20"
rustls-pemfile = "0.3"
Expand Down
1 change: 1 addition & 0 deletions libsignal-service-hyper/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ async-trait = "0.1"
base64 = "0.13"
bytes = "1.0"
futures = "0.3"
tracing = "0.1"
log = "0.4"
mpart-async = "0.6"
serde = "1.0"
Expand Down
2 changes: 2 additions & 0 deletions libsignal-service/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ thiserror = "1.0"
url = { version = "2.1", features = ["serde"] }
uuid = { version = "1", features = ["serde"] }

tracing = "0.1"

[build-dependencies]
prost-build = "0.10"

Expand Down
4 changes: 4 additions & 0 deletions libsignal-service/src/cipher.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ where
/// Opens ("decrypts") an envelope.
///
/// Envelopes may be empty, in which case this method returns `Ok(None)`
#[tracing::instrument]

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug` 

error[E0277]: `cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:61:5
    |
61  |     #[tracing::instrument]
    |     ^^^^^^^^^^^^^^^^^^^^^^ `cipher::ServiceCipher<S, R>` cannot be formatted using `{:?}`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `cipher::ServiceCipher<S, R>`
    = note: add `#[derive(Debug)]` to `cipher::ServiceCipher<S, R>` or manually `impl std::fmt::Debug for cipher::ServiceCipher<S, R>`
    = note: required for `&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 61 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
pub async fn open_envelope(
&mut self,
envelope: Envelope,
Expand Down Expand Up @@ -89,6 +90,7 @@ where
/// Triage of legacy messages happens inside this method, as opposed to the
/// Java implementation, because it makes the borrow checker and the
/// author happier.
#[tracing::instrument]

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug` 

error[E0277]: `cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:93:5
    |
93  |     #[tracing::instrument]
    |     ^^^^^^^^^^^^^^^^^^^^^^ `cipher::ServiceCipher<S, R>` cannot be formatted using `{:?}`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `cipher::ServiceCipher<S, R>`
    = note: add `#[derive(Debug)]` to `cipher::ServiceCipher<S, R>` or manually `impl std::fmt::Debug for cipher::ServiceCipher<S, R>`
    = note: required for `&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 93 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
async fn decrypt(
&mut self,
envelope: &Envelope,
Expand Down Expand Up @@ -263,6 +265,7 @@ where
Ok(plaintext)
}

#[tracing::instrument]

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug` 

error[E0277]: `cipher::ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:268:5
    |
268 |     #[tracing::instrument]
    |     ^^^^^^^^^^^^^^^^^^^^^^ `cipher::ServiceCipher<S, R>` cannot be formatted using `{:?}`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `cipher::ServiceCipher<S, R>`
    = note: add `#[derive(Debug)]` to `cipher::ServiceCipher<S, R>` or manually `impl std::fmt::Debug for cipher::ServiceCipher<S, R>`
    = note: required for `&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut cipher::ServiceCipher<S, R>` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`

Check failure on line 268 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`ServiceCipher<S, R>` doesn't implement `std::fmt::Debug`
pub(crate) async fn encrypt(
&mut self,
address: &ProtocolAddress,
Expand Down Expand Up @@ -417,6 +420,7 @@ pub async fn get_preferred_protocol_address<S: SessionStore>(
/// is then validated against the `trust_root` baked into the client to ensure that the sender's
/// identity was not forged.
#[allow(clippy::too_many_arguments)]
#[tracing::instrument]

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust beta) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::KyberPreKeyStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::KyberPreKeyStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::KyberPreKeyStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::KyberPreKeyStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::KyberPreKeyStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::KyberPreKeyStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::SenderKeyStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::SenderKeyStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::SenderKeyStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::SenderKeyStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::SenderKeyStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::SenderKeyStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::SignedPreKeyStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::SignedPreKeyStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::SignedPreKeyStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::SignedPreKeyStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::SignedPreKeyStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::SignedPreKeyStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::PreKeyStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::PreKeyStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::PreKeyStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::PreKeyStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::PreKeyStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::PreKeyStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::SessionStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::SessionStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::SessionStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::SessionStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::SessionStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::SessionStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / clippy

`dyn libsignal_protocol::IdentityKeyStore` doesn't implement `std::fmt::Debug` 

error[E0277]: `dyn libsignal_protocol::IdentityKeyStore` doesn't implement `std::fmt::Debug`
   --> libsignal-service/src/cipher.rs:423:1
    |
423 | #[tracing::instrument]
    | ^^^^^^^^^^^^^^^^^^^^^^ `dyn libsignal_protocol::IdentityKeyStore` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`
    |
    = help: the trait `std::fmt::Debug` is not implemented for `dyn libsignal_protocol::IdentityKeyStore`
    = help: the following other types implement trait `std::fmt::Debug`:
              (dyn tracing::Value + 'static)
              (dyn std::any::Any + 'static)
              (dyn std::any::Any + std::marker::Send + 'static)
              (dyn std::any::Any + std::marker::Send + std::marker::Sync + 'static)
    = note: required for `&mut dyn libsignal_protocol::IdentityKeyStore` to implement `std::fmt::Debug`
    = note: 1 redundant requirement hidden
    = note: required for `&&mut dyn libsignal_protocol::IdentityKeyStore` to implement `std::fmt::Debug`
note: required by a bound in `tracing::field::debug`
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tracing-core-0.1.31/src/field.rs:365:8
    |
363 | pub fn debug<T>(t: T) -> DebugValue<T>
    |        ----- required by a bound in this function
364 | where
365 |     T: fmt::Debug,
    |        ^^^^^^^^^^ required by this bound in `debug`
    = note: this error originates in the attribute macro `tracing::instrument` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust stable) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-hyper, Rust nightly) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust beta) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust stable) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`dyn IdentityKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`dyn SessionStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`dyn PreKeyStore` doesn't implement `std::fmt::Debug`

Check failure on line 423 in libsignal-service/src/cipher.rs

View workflow job for this annotation

GitHub Actions / Build (libsignal-service-actix, Rust nightly) 

`dyn SignedPreKeyStore` doesn't implement `std::fmt::Debug`
async fn sealed_sender_decrypt(
ciphertext: &[u8],
trust_root: &PublicKey,
Expand Down
1 change: 1 addition & 0 deletions libsignal-service/src/envelope.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ impl TryFrom<EnvelopeEntity> for Envelope {
}

impl Envelope {
#[tracing::instrument]
pub fn decrypt(
input: &[u8],
signaling_key: &SignalingKey,
Expand Down

0 comments on commit c3675b3

Please sign in to comment.