Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the match algorithm accept the URL struct #221

Merged
merged 6 commits into from
Feb 29, 2024

Commits on Feb 27, 2024

  1. Make test() and exec() accept URL

    The original specification did not explicitly accept a URL object as an
    input, and expected implicit conversion from the URL object to the
    URLPatternInit object for matching.
    
    This change make the URL object accepted as an input explicitly.
    This is a step to fix whatwg#218.
    yoshisatoyanagisawa committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9aa8046 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Addressed comments.

    - Not chagne `exec()` or `test()` arguments.
    - make the match algorithm accept [=/url=].
    - By merging existing steps, omitted the explicit declaration of
      anchors.
    yoshisatoyanagisawa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6983a8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e9b190 View commit details
    Browse the repository at this point in the history
  3. Update spec.bs

    Co-authored-by: Domenic Denicola <[email protected]>
    yoshisatoyanagisawa and domenic authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e2631be View commit details
    Browse the repository at this point in the history
  4. Applied the fix.

    yoshisatoyanagisawa committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3847bc6 View commit details
    Browse the repository at this point in the history
  5. Update spec.bs

    Co-authored-by: Jeremy Roman <[email protected]>
    yoshisatoyanagisawa and jeremyroman authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    483bccb View commit details
    Browse the repository at this point in the history