Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: export history handling behavior #10308

Merged
merged 4 commits into from
May 9, 2024

Conversation

yoshisatoyanagisawa
Copy link
Contributor

@yoshisatoyanagisawa yoshisatoyanagisawa commented Apr 30, 2024

It is used by the ServiceWorker specification.

I believe [=historyHandling=] in https://github.com/w3c/ServiceWorker/blob/main/docs/index.bs#L1456 is typo of [=history handling behavior=]. However, the phrase is not exported by the HTML specification yet.

  • At least two implementers are interested (and none opposed):
    • This change is for the ServiceWorker specification to refer the contents inside the HTML spec.
  • Tests are written and can be reviewed and commented upon at:
    • n/a
  • Implementation bugs are filed:
    • Chromium: has SW implementation
    • Gecko: has SW implementation
    • WebKit: has SW implementation
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): I do not know.
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): n/a
  • MDN issue is filed: n/a
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/webappapis.html ( diff )

yoshisatoyanagisawa added a commit to yoshisatoyanagisawa/ServiceWorker that referenced this pull request Apr 30, 2024
The CL depends on whatwg/html#10308 to be
merged because some symbols should be exported by the HTML
specification.
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are reasonable. However as noted in w3c/ServiceWorker#1715 (review) we should actually export https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigation-hh instead. That should have for="navigate".

While you are making these changes, could I ask you to add a few other improvements for consistency?

  • Export all other named arguments to "navigate", i.e. documentResource, response, exceptionsEnabled, historyHandling, navigationAPIState, formDataEntryList, referrerPolicy, userInvolvement

  • Use https://domenic.github.io/rewrapper/ to rewrap the modified paragraphs.

- unexport "history handling behavior", which is not needed.
- export under for="navigate" followings; documentResource, response,
  exceptionsEnabled, historyHandling, navigationAPIState, formDataEntryList,
  referrerPolicy, and userInvolvement.
@yoshisatoyanagisawa
Copy link
Contributor Author

These changes are reasonable. However as noted in w3c/ServiceWorker#1715 (review) we should actually export https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigation-hh instead. That should have for="navigate".

While you are making these changes, could I ask you to add a few other improvements for consistency?

  • Export all other named arguments to "navigate", i.e. documentResource, response, exceptionsEnabled, historyHandling, navigationAPIState, formDataEntryList, referrerPolicy, userInvolvement
  • Use https://domenic.github.io/rewrapper/ to rewrap the modified paragraphs.

Sure.
Done.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

source Show resolved Hide resolved
@domenic domenic merged commit fc23405 into whatwg:main May 9, 2024
2 checks passed
@yoshisatoyanagisawa yoshisatoyanagisawa deleted the export_history branch May 9, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants