-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: export history handling behavior #10308
Conversation
It is used by the ServiceWorker specification.
This is also used by the ServiceWorker specification. https://github.com/w3c/ServiceWorker/blob/main/docs/index.bs#L3112
The CL depends on whatwg/html#10308 to be merged because some symbols should be exported by the HTML specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are reasonable. However as noted in w3c/ServiceWorker#1715 (review) we should actually export https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigation-hh instead. That should have for="navigate"
.
While you are making these changes, could I ask you to add a few other improvements for consistency?
-
Export all other named arguments to "navigate", i.e. documentResource, response, exceptionsEnabled, historyHandling, navigationAPIState, formDataEntryList, referrerPolicy, userInvolvement
-
Use https://domenic.github.io/rewrapper/ to rewrap the modified paragraphs.
- unexport "history handling behavior", which is not needed. - export under for="navigate" followings; documentResource, response, exceptionsEnabled, historyHandling, navigationAPIState, formDataEntryList, referrerPolicy, and userInvolvement.
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It is used by the ServiceWorker specification.
I believe [=historyHandling=] in https://github.com/w3c/ServiceWorker/blob/main/docs/index.bs#L1456 is typo of [=history handling behavior=]. However, the phrase is not exported by the HTML specification yet.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/webappapis.html ( diff )