Clarify insertion order when prepending multiple bytes at once to ioQueue #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I signed up, do I have to do something else to unblock the PR? |
|
whatwg:main branch is broken: |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
I went for something slightly different as sequence itself is not really an established term outside of IDL: #328. Let me know what you think. |
|
Yes, this edit clarifies the order, thank you. |
|
Although the example for prepend should probably use the term |
|
Thanks! Good call on the example. Pushed a fix for that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main source of confusion for me was the absence of the keyword "sequence". This PR fixes that.
Fixes #325.
Preview | Diff