Making the plugin usable in SSR #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafuga
commented
Sep 16, 2024
rollup.config.mjs
Outdated
| @@ -30,7 +29,7 @@ export default [ | |||
| input: 'src/index.ts', | |||
| output: { | |||
| banner, | |||
| file: pkg.main, | |||
| dir: pkg.main, | |||
There was a problem hiding this comment.
Was getting a [!] RollupError: Invalid value for option "output.file" - when building multiple chunks, the "output.dir" option must be used, not "output.file". To inline dynamic imports, set the "inlineDynamicImports" option. error at build time without this change.
There was a problem hiding this comment.
If we're changing this, we either need to:
- Change the package.json so its not specifying filenames, and is instead specifying folder names. Right now its generating folders with filenames, you can see them in
./lib. - Switch instead to using
inlineDynamicImportsinstead, which will output a file and we can revert these changes. This will bundle it all into one file.
Unsure of which is better TBH. Worth some research?
There was a problem hiding this comment.
Just looked into it and my understanding is that using inlineDynamicImports will just bundle everything the way it was bundled before this PR so it's probably fine 🤔
There was a problem hiding this comment.
Changed the rollup configs to use inlineDynamicImports instead 👍
dafuga
changed the title
dafuga
force-pushed
the
making-useable-in-ssr
branch
from
25d02ec
to
2351939
Compare
dafuga
force-pushed
the
making-useable-in-ssr
branch
from
2351939
to
b7a7dc9
Compare
aaroncox
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.