Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable timestamps #37

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Disable timestamps #37

merged 1 commit into from
Nov 7, 2023

Conversation

RDruon
Copy link
Contributor

@RDruon RDruon commented Nov 7, 2023

Disable timestmaps in the metrics output as recommended by Prometheus documentation

@RDruon RDruon self-assigned this Nov 7, 2023
@RDruon RDruon force-pushed the disable_timestamp branch from 4386a05 to 9801791 Compare November 7, 2023 08:36
@jgrund
Copy link
Member

jgrund commented Nov 7, 2023

How does this effect the grafana lustre dashboard?

@RDruon
Copy link
Contributor Author

RDruon commented Nov 7, 2023

How does this effect the grafana lustre dashboard?

No effect, prometheus will simply append the timestamp with its current time rather than the one from the exporters.
This should also solve incorrect query response due to NTP not being used.

@jgrund jgrund merged commit 8db3433 into main Nov 7, 2023
9 checks passed
@jgrund jgrund deleted the disable_timestamp branch November 7, 2023 11:05
@jgrund
Copy link
Member

jgrund commented Nov 7, 2023

This needs a followon patch to increment versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants