Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add korea translation for cat facts (#304) #305

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

sonseong10
Copy link
Contributor

Description of Changes for Review #304

  • I created a new branch add_kor
  • a new file in ./src/models/localizations/kor-ko.js with korean translation.
  • test checks npm test

Also,
We appreciate the opportunity to contribute and look forward to helping you with any future edits or additions. 🙏

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #305 (623f757) into main (ad3e0aa) will increase coverage by 0.56%.
Report is 16 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   90.76%   91.32%   +0.56%     
==========================================
  Files          17       19       +2     
  Lines         184      196      +12     
==========================================
+ Hits          167      179      +12     
  Misses         17       17              
Files Changed Coverage Δ
src/models/localizations/ces-cz.js 100.00% <ø> (ø)
src/models/localizations/eng-us.js 100.00% <ø> (ø)
src/models/localizations/zho-tw.js 100.00% <ø> (ø)
src/models/localizations/ita-it.js 100.00% <100.00%> (ø)
src/models/localizations/kor-ko.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BeauBouchard BeauBouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sonseong10 I really appreciate your contribution. Great job!

@BeauBouchard BeauBouchard merged commit dc54350 into wh-iterabb-it:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants