Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Tagalog (Filipino) language #236

Merged
merged 2 commits into from
Jan 10, 2023
Merged

added Tagalog (Filipino) language #236

merged 2 commits into from
Jan 10, 2023

Conversation

mattazz
Copy link
Contributor

@mattazz mattazz commented Jan 8, 2023

Description of Changes for Review:

Translated the 90 cat facts from English to Tagalog (Filipino);
Update README (Supported Languages to include Tagalog);
Update package.json contributors.

closes #239

@@ -0,0 +1,107 @@
const facts = [
"Noong 1987, naunahan ng mga pusa ang aso bilang pinaka-sikat na alagang hayop sa America",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ever want to change these facts to make them fit the language's and local's culture more, its very appropriate and encouraged.

As an example this first fact could be changed to anything non-america

According to a survey in the philippines on pet ownership conducted by Rakuten Insight in January 2022, dogs were the most popular pets, with 81 percent of respondents saying they own a Dog over a Cat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to come back later and make additional contributions if you have some interesting facts as well 👏

Copy link
Member

@BeauBouchard BeauBouchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution!

@BeauBouchard BeauBouchard merged commit 2966fda into wh-iterabb-it:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] Tagalog (Filipino)
2 participants