Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/languages (#206) #208

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Enhancement/languages (#206) #208

merged 5 commits into from
Oct 31, 2022

Conversation

BeauBouchard
Copy link
Member

@BeauBouchard BeauBouchard commented Oct 31, 2022

Description

  • includes all of the changes from Enhancement/languages #206 from @nickcrisci
  • small change to a bad package-lock which was fixed that caused the CI to break
  • changed a little bit of the variable called (specifically their names) and tried to not add a new package by doing our own barrelling method in src/models/localization/index.js
  • added 2 more tests to check that everything was working :D

I am outlining the needed variables more thoroughly in #207 and have a new test issue to use it after this PR is merged. Great idea for making this all easier!

* Added requireDir dependency

* Index.js in Localization to export the whole dir, npm audit --fix in previous commit

* Added config information to module.export for each language

* Refactored code so that it no longer uses hardcoded lang values. Now dynamically loads all languages

* executet test:lint:fix to fix all linting errors

* Refactored require of localization to get rid of index.js
@BeauBouchard BeauBouchard added the enhancement New feature or request label Oct 31, 2022
@BeauBouchard
Copy link
Member Author

again, huge thanks to @nickcrisci for the quality contribution!

Copy link
Collaborator

@switchhalt switchhalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work all!

also I think that package-lock is what my problem was in #195

@switchhalt switchhalt merged commit 24b649b into main Oct 31, 2022
@switchhalt switchhalt deleted the refactor/languages branch October 31, 2022 17:33
@BeauBouchard BeauBouchard mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants