bugfix/wv-227 solution TEAM REVIEW #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pbnjcub in this PR have you reverted the code by Ivan after which this bug started appearing? If so, I think Ivan should also know about this as it may make the bug he was working on reappear again. |
|
Thanks Nishat, I am in contact with Ivan and he knows about it.
…On Mon, Mar 11, 2024 at 7:06 PM nishat-a ***@***.***> wrote:
@pbnjcub <https://github.com/pbnjcub> in this PR have you reverted the
code by Ivan after which this bug started appearing? If so, I think Ivan
should also know about this as it may make the bug he was working on
reappear again.
—
Reply to this email directly, view it on GitHub
<#3853 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZI3FIBCPIU4CLBSZUKWVFDYXZBGRAVCNFSM6AAAAABEQ4EH32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGYYTCNBUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
👍 Thank you @pbnjcub! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
WV-227
Changes included this pull request?
commented out the following lines in main.css
/* both of these commented lines cause the border issue around the input fields /
/ input:focus {
outline: var(--primary) solid 2px !important;
} */
/* input:focus-visible {
outline: var(--primary) solid 2px !important;
} */