Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WV-196] fix replace Nunito to Poppins font TEAM REVIEW #3842

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

ivanko22
Copy link
Contributor

@ivanko22 ivanko22 commented Feb 25, 2024

What github.com/wevote/WebApp/issues does this fix?

WV-192 fix replace Nunito to Poppins font
I experimented with using a font weight range, but encountered some issues with its functionality. As a result, I reverted to displaying each font weight individually. Additionally, I delved into the wght@ property to understand its role, discovering its association with the font-weight tag.

Changes included this pull request?

@ivanko22 ivanko22 changed the title [192] fix replace Nunito to Poppins font [WV-192] fix replace Nunito to Poppins font Feb 25, 2024
@ivanko22 ivanko22 changed the title [WV-192] fix replace Nunito to Poppins font [WV-192] fix replace Nunito to Poppins font TEAM REVIEW Feb 28, 2024
@ivanko22 ivanko22 changed the title [WV-192] fix replace Nunito to Poppins font TEAM REVIEW [WV-196] fix replace Nunito to Poppins font TEAM REVIEW Feb 28, 2024
@DaleMcGrew
Copy link
Member

Thank you @ivanko22, these changes look great. When I search WebApp/src for "Nunito Sans" (before this pull request) I also find items not included in this pull request.

Could you update those instances as well?
Screenshot 2024-02-29 at 7 05 52 AM

@ivanko22
Copy link
Contributor Author

@DaleMcGrew Done

@DaleMcGrew
Copy link
Member

👍 Thank you @ivanko22!

@DaleMcGrew DaleMcGrew merged commit 3c5e61d into wevote:develop Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants