-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WV-196] fix replace Nunito to Poppins font and storybook-static to .gitignore #3840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y (Part 2) Now do the redirect in App.jsx. New https requests will be intercepted before they get to the React Router, and the DOM window.location.hrf and if pointed at /storybook will be reset to the desired /storybook/index.html Works fine locally (as did the prior approach), we will see how it does on the production servers. Implements https://wevoteusa.atlassian.net/browse/WV-206
…ixed a few ESLINT warnings/errors. Turned off RepresentativeList when no data found.
Works on Safari and Firefox for webapp, but not on Chrome. Works on Chrome for local Python API server.
Works on Safari and Firefox for webapp, but not on Chrome. Works on Chrome for local Python API server.
Works on Safari and Firefox for webapp, but not on Chrome. Works on Chrome for local Python API server.
Works on Safari and Firefox for webapp, but not on Chrome. Works on Chrome for local Python API server.
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Updated packages related to Webpack (to no avail) Added serverWevotedeveloper.js to prove usability of Chrome with the express webserver server.
Updated packages related to Webpack (to no avail) Added serverWevotedeveloper.js to prove usability of Chrome with the express webserver server.
Updated packages related to Webpack (to no avail) Added serverWevotedeveloper.js to prove usability of Chrome with the express webserver server.
…ic from repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github.com/wevote/WebApp/issues does this fix?
@DaleMcGrew, I tried using a font weight range but ran into issues, so I went back to displaying each font weight separately. I also looked into the wght@ property and found it's related to the font-weight tag. Additionally, Storybook showed up in my commit history again, so I added it back to the .gitignore file.
Changes included in this pull request?