Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-135 #3767

Closed
wants to merge 19 commits into from
Closed

WV-135 #3767

wants to merge 19 commits into from

Conversation

ivanko22
Copy link
Contributor

@ivanko22 ivanko22 commented Nov 3, 2023

What github.com/wevote/WebApp/issues does this fix?

Fix CSS on ballot candidate according to WV-135

Changes included this pull request?

Ivan Kordonets and others added 19 commits October 22, 2023 22:03
…and Android

Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157  The App loses main menu for signed-in users
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155  Re-enabled "Help them win" on Candidate pages for Cordova.
When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not.
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152   Title of "Sign In with Mobile Number" field cut off
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156   User can't close the "Complete your support" page on some iOS Devices
…and Android

Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-157  The App loses main menu for signed-in users
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-155  Re-enabled "Help them win" on Candidate pages for Cordova.
When I work on css issues in Cordova, I have to work backwards from DOM element, so it is important that StyledComponents have a name that resolves to a single object in the code --- SignInOptionsPanelWrapper was uncopied where possible, renamed where not.
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-152   Title of "Sign In with Mobile Number" field cut off
Resolves https://wevoteusa.atlassian.net/jira/software/projects/WV/issues/WV-156   User can't close the "Complete your support" page on some iOS Devices
…to prevent string methods from trying to execute with a null value
@ivanko22 ivanko22 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants