-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new init method + expose preference object #4409
Conversation
🦋 Changeset detectedLatest commit: 9fe8700 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Felix. Looks good. This likely warrants a major version bump on the connectors pkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane and good to me
1bfe6a4
to
6a99a27
Compare
50bb7a0
to
1348a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont understand it completely, sorry
In latest
@coinbase/wallet-sdk
, we enriched one of the config param,preference
, to be able to takeattribution
for onchain analytics,keysUrl
for testing against different smart wallet env. So updating@wagmi/connectors
to expose this new preference object to end users.CoinbaseWalletSDK
with the newly-introducedcreateCoinbaseWalletSDK
to better align w js normDemo
Screen.Recording.2024-11-13.at.10.49.32.AM.mov