Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new init method + expose preference object #4409

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

fan-zhang-sv
Copy link
Contributor

In latest @coinbase/wallet-sdk, we enriched one of the config param, preference, to be able to take attribution for onchain analytics, keysUrl for testing against different smart wallet env. So updating @wagmi/connectors to expose this new preference object to end users.

  • this preference object can take arbitrary param, so it provides more flexibility to end user as we push out more new params
  • this PR also replaced the deprecated class CoinbaseWalletSDK with the newly-introduced createCoinbaseWalletSDK to better align w js norm

Demo

Screen.Recording.2024-11-13.at.10.49.32.AM.mov

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 9fe8700

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@wagmi/connectors Minor
wagmi Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 4:13pm

Copy link
Contributor

@cb-jake cb-jake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Felix. Looks good. This likely warrants a major version bump on the connectors pkg

Copy link

@spencerstock spencerstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane and good to me

@tmm tmm merged commit 7ca62b4 into wevm:main Nov 15, 2024
3 of 5 checks passed
Copy link

@Svenne1980 Svenne1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand it completely, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants