Merge pull request #322 from z2014/master

fix: issue 320
weui · Jul 23, 2020 · 494113a · 494113a
2 parents 232fb94 + dcc929b
commit 494113a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ### CHANGELOG
 
+#### 1.2.3
+
+- fix: issue 320
+
 #### 1.2.2
 
 Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-weui",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "weui for react",
   "main": "./build/packages/index.js",
   "scripts": {

diff --git a/src/components/dialog/dialog.js b/src/components/dialog/dialog.js
@@ -48,15 +48,29 @@ class Dialog extends Component {
 
     renderButtons() {
         return this.props.buttons.map((action, idx) => {
-            const {type, label, ...others} = action;
+            const {type, label, onClick, ...others} = action;
             const className = classNames({
                 'weui-dialog__btn': true,
                 'weui-dialog__btn_default': type === 'default',
                 'weui-dialog__btn_primary': type === 'primary'
             });
 
             return (
-                <a key={idx} href="javascript:;" {...others} className={className}>{label}</a>
+                <a
+                    key={idx}
+                    href="#"
+                    onClick={(e) => {
+                        if (e) {
+                            e.preventDefault();
+                        }
+                        if (onClick && typeof onClick === 'function') {
+                            onClick(e);
+                        }
+                        return false;
+                    }}
+                    {...others}
+                    className={className}
+                >{label}</a>
             );
         });
     }