update from carltongibson/neapolitan upstream
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `app_config.path` in more correct, since it leverages Django's app folder discovery, allowing apps to be placed in various locations.
Route only some roles:
BookmarkView.get_urls(roles={Role.LIST, Role.DETAIL})
Plus, specify url_base, and path_converter for URL routing.
Co-authored-by: Kasun Herath <[email protected]>
…to bump-upstream
jefftriplett
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in all recent commits missing from our fork.
Needed some manual intervention since our fork has diverged a bit.