Fix memory leak in join handler #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The private callback data is only available is only exposed in the API when a callback is called. In a scenario where the private data has been dynamically allocated on the heap and the event is deleted outside of the callback this is problematic since the user of the API has no way of deallocating this data. This patch adds a new optional callback that gets called during the deletion of an event. It is then possible to do what ever clean up is necessary in this callback. Signed-off-by: Jacques de Laval <[email protected]>
The timer for deleting a group entry has associated data allocated on the heap. This data must be freed not only when the timer times out, but also when receiving a new join for the same group in which case we replace the currently active timer. Signed-off-by: Jacques de Laval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer for deleting a group entry has associated data allocated on the heap. This data must be freed not only when the timer times out, but also when receiving a new join for the same group in which case we replace the currently active timer.
This PR adds a few functions to the pev API. If this PR is accepted I'll try to upstream these to https://github.com/troglobit/pev/