Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run entrypoint script with ENTRYPOINT instead of CMD #67

Closed
wants to merge 1 commit into from
Closed

Run entrypoint script with ENTRYPOINT instead of CMD #67

wants to merge 1 commit into from

Conversation

muripic
Copy link

@muripic muripic commented Jul 30, 2021

Fixes #65.

As stated in the official doc, the main purpose of the CMD instruction is to provide a default. If this default is overridden when running docker run, the default will not run.
A better instruction to run the entrypoint script, therefore, is ENTRYPOINT, which will always run unless it's explicitly overridden with the --entrypoint flag.

@muripic muripic closed this Jul 31, 2021
@muripic
Copy link
Author

muripic commented Jul 31, 2021

I testedI got an error when using it with docker-compose because the entrypoint script actually executes ngrok, and realized that these use cases are covered by passing a value such as service:8080 to the envvar NGROK_PORT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGROK_AUTH not working
1 participant