-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feature/add #6077
WIP: Feature/add #6077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense that you can update the sortable option via method updateColumnTitle
.
As the method name already says update column TITLE.
Then we have a method which name says update title but also could update the sortable option.
Do you think add a new method like |
I guess a method |
$el.removeClass('sortable both asc desc') | ||
} | ||
} | ||
$(el).data(column) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're instantiating a lot of jquery object with
Any news here @wenzhixin ? |
I think it's okay to set it up directly with the So let's close this PR? |
We can either change the method name or implement a new method where we can change all the column config |
I think we should add a new method which allowes to change all column options as @djhvscf said, but i guess this has no high priority yet. |
🤔Type of Request
🔗Resolves an issue?
Fix #6058
📝Changelog
💡Example(s)?
Before: https://live.bootstrap-table.com/code/antonioaltamura/10565
After: https://live.bootstrap-table.com/code/wenzhixin/10788
☑️Self Check before Merge